D13970: Handle empty preview lists

cordlandwehr added a reviewer: dhaumann. cordlandwehr added a comment. Somehow removed all reviewers with my last message (sorry!) Trying to fix this now. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13970 To: cordlandwehr, dhaumann Cc: kde-frameworks-devel, m

D13970: Handle empty preview lists

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R304:c4275aaf79fc: Handle empty preview lists (authored by cordlandwehr). REPOSITORY R304 KNewStuff CHANGES SINCE LAST U

D13970: Handle empty preview lists

cordlandwehr removed reviewers: gregormi, nicolasfella, dhaumann, Frameworks. cordlandwehr added a comment. This revision now requires review to proceed. I had a crash at the respective locations while porting Artikulate to the QtQuick based API, since those KNS resource files do not provide p

D13970: Handle empty preview lists

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. In any case, this patch will not break things. REPOSITORY R304 KNewStuff BRANCH bugfix/allowEmptyPreviewLists REVISION DETAIL https://phabricator.kde.org/D13970 To: cordlandwehr

D13970: Handle empty preview lists

gregormi added a comment. I am rather familiar with KMoreTools but not with the rest of KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13970 To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bru

D13970: Handle empty preview lists

dhaumann added a comment. Which bug in which context does this fix? The information given is a bit 'thin' ;-) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13970 To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks Cc: kde-frameworks-devel, michaelh,

D13970: Handle empty preview lists

ngraham added reviewers: gregormi, nicolasfella, dhaumann, Frameworks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13970 To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13970: Handle empty preview lists

cordlandwehr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Do not access the first list's element if the list possibly might be empty.