D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

2019-04-09 Thread Kai Uwe Broulik 
broulik abandoned this revision.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14290

To: broulik, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

2018-07-30 Thread David Faure 
dfaure added a comment.


  Why is this called with an invalid URL?
  
  The bug report says "copy/move a big file to another device/partition."  -- 
surely the destination should be valid? It sounds like this patch is masking a 
real bug...

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14290

To: broulik, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

2018-07-30 Thread David Faure 
dfaure requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14290

To: broulik, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

2018-07-28 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  +1

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14290

To: broulik, dfaure
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

2018-07-23 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It checks whether the file is not in `TEMP` but it doesn't check whether the 
`QUrl` is valid.
  It opens `destination` when you click the button which fails when it is 
invalid/empty.
  
  CCBUG: 396738

TEST PLAN
  Buttons no longer show when there is no destination

REPOSITORY
  R288 KJobWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14290

AFFECTED FILES
  src/kwidgetjobtracker.cpp

To: broulik, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns