This revision was automatically updated to reflect the committed changes.
Closed by commit R249:64796250e69d: Check the build directory for po/ as well
(authored by apol).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14572?vs=39196=39233
REVISION DETAIL
dfaure accepted this revision.
REPOSITORY
R249 KI18n
BRANCH
arcpatch-D14572
REVISION DETAIL
https://phabricator.kde.org/D14572
To: apol, #frameworks, ltoscano, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns
ltoscano accepted this revision.
ltoscano added a comment.
It was basically already approved, and it already made sense. The only
requested change (a comment) was applied.
REPOSITORY
R249 KI18n
BRANCH
arcpatch-D14572
REVISION DETAIL
https://phabricator.kde.org/D14572
To: apol,
apol updated this revision to Diff 39196.
apol added a comment.
Added David's recommended comment
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14572?vs=38988=39196
BRANCH
arcpatch-D14572
REVISION DETAIL
https://phabricator.kde.org/D14572
AFFECTED
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> KF5I18nMacros.cmake.in:111
>
> +get_filename_component(absolute_podir ${podir} ABSOLUTE)
> +
For symmetry add a comment to this line too, then? Something like:
apol created this revision.
apol added reviewers: Frameworks, ltoscano.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
Instead of just checking if it's in the source
