dfaure closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14662
To: dfaure, rkflx, shubham, ngraham
Cc: bruns, michaelh, kde-frameworks-devel, ngraham
dfaure added inline comments.
INLINE COMMENTS
> rkflx wrote in kpropertiesdialog.cpp:853
> Just out of interest (don't change anything): I assume you don't fully
> transition everything to `d->m_grid` to keep the diff small, or because
> `grid` is more readable?
Yeah, a bit of both, mostly to
rkflx accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
kpropsdlg
REVISION DETAIL
https://phabricator.kde.org/D14662
To: dfaure, rkflx, shubham, ngraham
Cc: bruns, michaelh, kde-frameworks-devel, ngraham
dfaure updated this revision to Diff 39291.
dfaure added a comment.
Handle multiple calls to setFileNameReadOnly(true), just in case.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14662?vs=39232=39291
BRANCH
kpropsdlg
REVISION DETAIL
rkflx added a comment.
Thanks for the help. Works great, just one inline question about an edge case
(everything else LGTM).
INLINE COMMENTS
> kpropertiesdialog.cpp:853
> QGridLayout *grid = new QGridLayout(); // unknown rows
> +d->m_grid = grid;
> grid->setColumnStretch(0,
dfaure created this revision.
dfaure added reviewers: rkflx, shubham, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
dfaure requested review of this revision.
REVISION SUMMARY
for
