D14723: Add option to disable KWallet entirely in the new wallet dialog

[David Faure]

dfaure added a comment.


  The patch looks OK to me, but yeah, it should be emphasized that disabling 
KWallet *reduces* security greatly.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: aacid, dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> aacid wrote in knewwalletdialog.h:67
> do we really need to rename this?

It's not just a rename - it's doing the opposite now as there are three instead 
of two actions.

If you follow which slot this ends up, it's responsible for switching between 
"Next" and "Finished" buttons in the step. Next is only shown if GPG is 
selected, so this makes IMO more sense.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: aacid, dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Fabian Vogt]

fvogt updated this revision to Diff 40079.
fvogt added a comment.


  Quit kwalletd if option was selected.
  
  The .sync is necessary because the change is made in a KSharedConfig but read
  by the simple KConfig in reconfigure. I guess it should use KSharedConfig
  everywhere and just call "reparseConfiguration" in reconfigure manually. 
That's
  something for another patch however.

REPOSITORY
  R311 KWallet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14723?vs=39396&id=40079

BRANCH
  disableopt

REVISION DETAIL
  https://phabricator.kde.org/D14723

AFFECTED FILES
  src/runtime/kwalletd/knewwalletdialog.cpp
  src/runtime/kwalletd/knewwalletdialog.h
  src/runtime/kwalletd/knewwalletdialogintro.ui
  src/runtime/kwalletd/kwalletd.cpp

To: fvogt, #frameworks
Cc: aacid, dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Fabian Vogt]

fvogt added a comment.


  In D14723#306659 , @aacid wrote:
  
  > Isn't this actually bad for the privacy goal? AFAIK some apps will just 
write the password in cleartext in a config file when kwallet is not present.
  
  
  It's not selected by default - but maybe that can be emphasized in the 
option's name?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: aacid, dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Albert Astals Cid]

aacid added a comment.


  Isn't this actually bad for the privacy goal? AFAIK some apps will just write 
the password in cleartext in a config file when kwallet is not present.

INLINE COMMENTS

> knewwalletdialog.h:67
>  protected Q_SLOTS:
> -void onBlowfishToggled(bool);
> +void onGpgToggled(bool);
>  private:

do we really need to rename this?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: aacid, dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Nathaniel Graham]

ngraham added a comment.


  +1 conceptually, as this seems relevant to the privacy initiative as well.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[David Faure]

dfaure added a comment.


  +1, looks good to me (I just wonder how well KDE applications actually behave 
with KWallet disabled...)

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: dfaure, kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Fabian Vogt]

fvogt added a comment.


  This fixes part of a downstream bug report: 
https://bugzilla.opensuse.org/show_bug.cgi?id=1104462

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D14723

To: fvogt, #frameworks
Cc: kde-frameworks-devel, ngraham, michaelh, bruns

D14723: Add option to disable KWallet entirely in the new wallet dialog

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
fvogt requested review of this revision.

REVISION SUMMARY
  Users are greeted by this dialog on the first request by any application.
  Even if they press cancel, the dialog will pop up on subsequent requests 
again.
  The only way to disable this is using the KCM, which is not intuitive enough.
  So add a new option to the new wallet creation dialog.

TEST PLAN
  Selected the option, kwallet is now disabled.

REPOSITORY
  R311 KWallet

BRANCH
  disableopt

REVISION DETAIL
  https://phabricator.kde.org/D14723

AFFECTED FILES
  src/runtime/kwalletd/knewwalletdialog.cpp
  src/runtime/kwalletd/knewwalletdialog.h
  src/runtime/kwalletd/knewwalletdialogintro.ui
  src/runtime/kwalletd/kwalletd.cpp

To: fvogt, #frameworks
Cc: kde-frameworks-devel, ngraham, michaelh, bruns