D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309388 , @habacker wrote: > Agreed, as long as there is Qt on Windows not patched to also use unix style path layout, which is the case on OBS but this case should be covered by ECM module

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309370 , @bcooksley wrote: > On Windows the correct path to use is $prefix/bin/data/... as that is what QStandardPaths expects. > The location $prefix/share/ won't work on Windows, so the test will need

D14817: Convert manual install test to an autotest

habacker added a comment. another option would be to force the install path in the cmake call add_test(kdoctools_install ${CMAKE_CTEST_COMMAND} --build-and-test "${CMAKE_CURRENT_SOURCE_DIR}/kdoctools-install" "${CMAKE_CURRENT_BINARY_DIR}/kdoctools-install"

D14817: Convert manual install test to an autotest

habacker added a comment. Because test.qmake do not anything about KDE install path layout those pathes need to be specified in the ctest config in autotests/CMakeLists.txt I guess --test-command ${CMAKE_COMMAND} "-DKDE_INSTALL_MANDIR=${KDE_INSTALL_MANDIR}"

D14817: Convert manual install test to an autotest

bcooksley added a comment. On Windows the correct path to use is $prefix/bin/data/... as that is what QStandardPaths expects. The location $prefix/share/ won't work on Windows, so the test will need to handle that case. REPOSITORY R238 KDocTools REVISION DETAIL

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309332 , @bcooksley wrote: > The Windows failure looks like a problem with handling of DESTDIR - probably due to reliance on it being handled by $DESTDIR instead of %DESTDIR% (which is the correct syntax for

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309303 , @bcooksley wrote: > Try removing that and the error it has should show up on your local system I see. Since this problem has been fixed in kdoctools git repo and kdoctools has been rebuilt

D14817: Convert manual install test to an autotest

bcooksley added a comment. The Windows failure looks like a problem with handling of DESTDIR - probably due to reliance on it being handled by $DESTDIR instead of %DESTDIR% (which is the correct syntax for Windows) REPOSITORY R238 KDocTools REVISION DETAIL

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309295 , @habacker wrote: > According to https://cgit.kde.org/kdoctools.git/tree/src/meinproc.cpp#n51 uses meinproc5 qCCritical(KDocToolsLog) - How can this be enabled on KDE CI ? Got it - see

D14817: Convert manual install test to an autotest

bcooksley added a comment. You aren't seeing the error the CI system sees because your build prefix still exists. Try removing that and the error it has should show up on your local system REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D14817 To: habacker,

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309281 , @bcooksley wrote: > Dependency Builds triggered to roll it out to all the non Frameworks jobs which have already picked this up. How to do this ? REPOSITORY R238 KDocTools REVISION DETAIL

D14817: Convert manual install test to an autotest

habacker added a comment. According to https://cgit.kde.org/kdoctools.git/tree/src/meinproc.cpp#n51 uses meinproc5 qCCritical(KDocToolsLog) - How can this be enabled on KDE CI ? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D14817 To: habacker, ltoscano Cc:

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309285 , @habacker wrote: > Funny, that this works with Qt 5.9 https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.9/ and Qt 5.11 (locally tested) - it only happens with Qt 5.10

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309283 , @habacker wrote: > This is the remaining issue on non Windows KDE CI Qt 5.10 > > https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/consoleFull > > 07:02:43 cd

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#309281 , @bcooksley wrote: > This change has caused CI wide breakage and makes kdoctools unrelocatable. This has been fixed with commit

D14817: Convert manual install test to an autotest

habacker added a comment. This is the remaining issue on non Windows KDE CI Qt 5.10 https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/49/consoleFull 07:02:43 cd "/home/jenkins/workspace/Frameworks kdoctools kf5-qt5 SUSEQt5.10/autotests/kdoctools-install" &&

D14817: Convert manual install test to an autotest

bcooksley added a comment. This change has caused CI wide breakage and makes kdoctools unrelocatable. It needs to be reverted urgently, and Dependency Builds triggered to roll it out to all the non Frameworks jobs which have already picked this up. REPOSITORY R238 KDocTools REVISION

D14817: Convert manual install test to an autotest

habacker added a comment. I applied a fix to use absolute pathes. Unfortunally windows builds have an additional issue: > https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.10/36/console 21:26:34 -- Installing: C:/CI/workspace/Frameworks kdoctools kf5-qt5

D14817: Convert manual install test to an autotest

habacker added a comment. In D14817#308903 , @ltoscano wrote: > This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI seems to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on openSUSE/Qt 5.9 and FreeBSD/Qt

D14817: Convert manual install test to an autotest

ltoscano added a comment. This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI seems to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on openSUSE/Qt 5.9 and FreeBSD/Qt 5.10): - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/46/

D14817: Convert manual install test to an autotest

This revision was automatically updated to reflect the committed changes. Closed by commit R238:f0cc8b2ccb4a: Convert manual install test to an autotest (authored by habacker). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. CHANGED PRIOR TO COMMIT