D14828: remove highlighting download dialog
cullmann added a comment. Independent of mom/dad/somebody else, for highlighting files you create on your own, you just can perfectly add them to the local directories as specified in the manual. If you really want to have new highlighting files and risk that stuff like indenters or included stuff might break, you can still get them from the syntax-highlighting git and put them in that folders manually, too. The only thing that is no longer there is the "auto" download dialog. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14828 To: cullmann, dhaumann Cc: rjvbb, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14828: remove highlighting download dialog
rjvbb added a comment. Downloading already didn't work for me since quite a while (the operation never completed) but what does this mean for highlighting files I write myself (or someone's mom does)? > Other users who do not follow the latest development releases [...] are likely not the target audience for downloading highlighting files. I take a bit exception with this; users of certain distributions that aim to allow them to work *with* the software instead of *on* (as in applying updates) are being compared with a rather negative and probably sexist view of their mother. The opposite is true for many such users: working with stable releases means you have more reason to update things like highlighting files. FWIW, there was never a reason to have a download/update button in the "userland" configure UI; a KCM provided by the highlighting framework would make perfect sense (that same KCM could serve to disable/uninstall useless highlighting files; your mom probably doesn't need more than half the ones that get installed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14828 To: cullmann, dhaumann Cc: rjvbb, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14828: remove highlighting download dialog
This revision was automatically updated to reflect the committed changes. Closed by commit R39:705f8e0419c4: remove highlighting download dialog (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14828?vs=39686=39688 REVISION DETAIL https://phabricator.kde.org/D14828 AFFECTED FILES src/dialogs/filetypeconfigwidget.ui src/dialogs/katedialogs.cpp src/dialogs/katedialogs.h src/mode/katemodeconfigpage.cpp src/mode/katemodeconfigpage.h To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14828: remove highlighting download dialog
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good. But along with this change, please change the docbook in kate.git: We have doc/katepart/configuring.docbook Download Highlighting Files... Click this button to download new or updated syntax highlight descriptions from the website. And we have: doc/katepart/development.docbook You can download updated or additional syntax highlight definitions from the website by clicking the Download Highlighting Files... button in the Modes Filetypes tab of the Config Dialog. REPOSITORY R39 KTextEditor BRANCH no-hl-download (branched from master) REVISION DETAIL https://phabricator.kde.org/D14828 To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
D14828: remove highlighting download dialog
cullmann created this revision. cullmann added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY rational: 1. there is one frameworks release per month that already provides a stream of hl updates 2. often new highlightings anyways need a new frameworks version 3. one can easily update only a part of the files which leads to broken other highlighting that include parts of them 4. the updates might easily break the non-downloadable indenters GUI: highlighting download dialog removed TEST PLAN make make test REPOSITORY R39 KTextEditor BRANCH no-hl-download (branched from master) REVISION DETAIL https://phabricator.kde.org/D14828 AFFECTED FILES src/dialogs/filetypeconfigwidget.ui src/dialogs/katedialogs.cpp src/dialogs/katedialogs.h src/mode/katemodeconfigpage.cpp src/mode/katemodeconfigpage.h To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
