D14894: [RFC] Fix block mode for multi-cursor branch

2018-08-17 Thread Sven Brauch 
brauch added a comment.


  Thanks for the patch, the approach looks reasonable at a first glance. You 
might want to unite the up/down functions ...
  It is too much of a WiP to merge it like this, though.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14894

To: lepagevalleeemmanuel, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14894: [RFC] Fix block mode for multi-cursor branch

2018-08-16 Thread Emmanuel Lepage Vallee 
lepagevalleeemmanuel created this revision.
lepagevalleeemmanuel added a reviewer: brauch.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
lepagevalleeemmanuel requested review of this revision.

REVISION SUMMARY
  This is a rough patch to allow cursors past the end of the line when the "new 
block mode" action is checked. It doesn't improve that much upon the "it's 
fully broken" current state, but at least restore the capability to select past 
the end of the line and create multi-row vertical cursors using the keyboard.
  
  This is a "code dump" more than a "I will be responsive forever about this 
code review". I said I would fix this and this patch does it. I hope it helps 
give some energy back into this branch and I hope it gets merged in the future.

TEST PLAN
  none, it's barely working.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D14894

AFFECTED FILES
  src/include/ktexteditor/view.h
  src/view/katemulticursor.cpp
  src/view/kateview.cpp
  src/view/kateview.h

To: lepagevalleeemmanuel, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann