D15099: add a new property headerVisible

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R236:9069ae42435c: add a new property headerVisible (authored 
by mart).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15099?vs=40504=43278

REVISION DETAIL
  https://phabricator.kde.org/D15099

AFFECTED FILES
  src/kpagemodel.h
  src/kpageview.cpp
  src/kpagewidgetmodel.cpp
  src/kpagewidgetmodel.h

To: mart, #plasma, #frameworks, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  phab/headerVisible

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks, davidedmundson
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Andres Betts]

abetts added a comment.


  Thanks for the work Marco!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Marco Martin]

mart updated this revision to Diff 40504.
mart added a comment.


  - emit changed

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15099?vs=40501=40504

BRANCH
  phab/headerVisible

REVISION DETAIL
  https://phabricator.kde.org/D15099

AFFECTED FILES
  src/kpagemodel.h
  src/kpageview.cpp
  src/kpagewidgetmodel.cpp
  src/kpagewidgetmodel.h

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Marco Martin]

mart added a comment.


  KCM showing its own title
  F6218375: Spectacle.y22236.png 
  Ttile shown by KPageWidget
  F6218377: Spectacle.S22236.png 

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Marco Martin]

mart added a reviewer: Frameworks.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D15099

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15099: add a new property headerVisible

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  add a new property in KPageWidgetItem, headerVisible
  this way the page can control whether or not make its own header
  visible.
  This is necessary for the new systemsettings in which the new
  QML kcms display their own title, but the old QWidget based ones
  don't and have the KPageWidget display it for them.

TEST PLAN
  tested in systemsettings

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  phab/headerVisible

REVISION DETAIL
  https://phabricator.kde.org/D15099

AFFECTED FILES
  src/kpagemodel.h
  src/kpageview.cpp
  src/kpagewidgetmodel.cpp
  src/kpagewidgetmodel.h

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns