cullmann added a comment.
:=)
The second lookup round over all included rules in the context did really
hide some things.
Now we properly keep track which context is needed to be used for the lookup.
2321fc443483fb5669f9092980c7ab25bf78778d
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2321fc443483: try to fix unit tests (authored by
cullmann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D15207?vs=40827=40830#toc
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Hmm, tests are unstable :/
I did run them here now X times, they are stable. Perhaps depending on which
highlightings got parsed in which order.
Why should then the id's be equal
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:91d29a45389e: precompute attribute format for context
rules (authored by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15207
To: cullmann, vkrause, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,
cullmann added a comment.
I inlined the MatchResult, it is used the whole time and given it is purely
internal, one doesn't need to waste cycles for having calls to get the two ints
and the reference to the stringlist.
The implicit constructor now doesn't play around with the stringlist
cullmann updated this revision to Diff 40826.
cullmann added a comment.
inline MatchResult, very often used, no need to waste time for calls
fix scoping in Repository::definitionForMimeType
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
cullmann created this revision.
cullmann added reviewers: vkrause, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.
REVISION SUMMARY
avoid costly lookup, e.g. 3% of runtime of
