D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

2018-09-10 Thread Kai Uwe Broulik 
broulik abandoned this revision.
broulik added a comment.


  Was an idea :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15242

To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

2018-09-06 Thread Fabian Vogt 
fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  This will likely not work with ACLs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15242

To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

2018-09-03 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: dfaure, elvisangelaccio, fvogt, lbeltrame.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoids creating a `QFileInfo` which might block `stat`'ing the file, 
especially if the information has been filled in by a KIO slave already.

TEST PLAN
  - Unittest still passes
  - Had an own file that I removed the own permission → became unreadable
  - Had a file from someone else but in the same group as me → was readable

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15242

AFFECTED FILES
  src/core/kfileitem.cpp

To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns