D15421: [server] Add surface data proxy mechanism

2019-02-06 Thread Roman Gilg 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:0b33f078bd1d: [server] Add surface data proxy mechanism 
(authored by romangg).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D15421?vs=48515=51027#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15421?vs=48515=51027

REVISION DETAIL
  https://phabricator.kde.org/D15421

AFFECTED FILES
  src/server/datadevice_interface.cpp
  src/server/datadevice_interface.h
  src/server/pointer_interface.cpp
  src/server/seat_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h
  src/server/surface_interface_p.h

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2019-01-02 Thread Roman Gilg 
romangg updated this revision to Diff 48515.
romangg added a comment.


  - Fix typo
  - Rebase on master.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15421?vs=41497=48515

BRANCH
  0proxyDataSurface

REVISION DETAIL
  https://phabricator.kde.org/D15421

AFFECTED FILES
  src/server/datadevice_interface.cpp
  src/server/datadevice_interface.h
  src/server/pointer_interface.cpp
  src/server/seat_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h
  src/server/surface_interface_p.h

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2019-01-02 Thread Roman Gilg 
romangg marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2018-10-04 Thread David Edmundson 
davidedmundson added a comment.


  Seems ok, I need to re-read it in the context of the other patches that I'm 
getting through.

INLINE COMMENTS

> surface_interface.h:268
> + * Setting a data proxy is only allowed when the client owning this 
> surface
> + * has not creted a data device itself.
> + * @since 5.XX

creted -> created.

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2018-09-20 Thread Roman Gilg 
romangg added a dependent revision: D15627: [xwl] Drag and drop between 
Xwayland and Wayland native clients.

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2018-09-12 Thread Roman Gilg 
romangg updated this revision to Diff 41497.
romangg added a comment.


  Remove updateProxy call on pointer button press. The compositor is instead
  responsible for updating it before a drag starts, what allows more freedom
  in how the proxy is used.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15421?vs=41395=41497

BRANCH
  0proxyDataSurface

REVISION DETAIL
  https://phabricator.kde.org/D15421

AFFECTED FILES
  src/server/datadevice_interface.cpp
  src/server/datadevice_interface.h
  src/server/pointer_interface.cpp
  src/server/seat_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h
  src/server/surface_interface_p.h

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2018-09-11 Thread Roman Gilg 
romangg added a comment.


  Thinking about it again it makes probably more sense to only allow one proxy 
surface per remote. Otherwise a drag remote can change mid-drag when a user 
presses a second button while the drag is going on.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2018-09-11 Thread Roman Gilg 
romangg set the repository for this revision to R127 KWayland.
romangg added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15421: [server] Add surface data proxy mechanism

2018-09-11 Thread Roman Gilg 
romangg added a dependency: D15023: [server] Add selectionChanged signal.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D15421

To: romangg, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns