D15583: [Balooctl] remove directory parent check

2018-09-29 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:2452ce28193a: [Balooctl] remove directory parent check 
(authored by ngraham).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15583?vs=42152=42576

REVISION DETAIL
  https://phabricator.kde.org/D15583

AFFECTED FILES
  src/tools/balooctl/configcommand.cpp

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15583: [Balooctl] remove directory parent check

2018-09-29 Thread Stefan Brüns
bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  arcpatch-D15583

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15583: [Balooctl] remove directory parent check

2018-09-24 Thread Nathaniel Graham
ngraham added a comment.


  https://phabricator.kde.org/D15583?id=42018 didn't let you add `~/foo/bar` to 
the list of includes or excludes if `~/foo` was already present.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15583: [Balooctl] remove directory parent check

2018-09-24 Thread James Smith
smithjd added a comment.


  What was wrong with https://phabricator.kde.org/D15583?id=42018 ?
  
  > I could see the case for allowing this behavior to be explicitly overridden 
by an advanced user who marks ~/foo/ as excluded and then later marks ~foo/bar/ 
as included, but that would be material for another patch I think.
  
  This is actually already how this works, the excludes and includes are both 
resolved into either an index path or do not index path outcome.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15583: [Balooctl] remove directory parent check

2018-09-23 Thread Stefan Brüns
bruns added a comment.


  In D15583#330799 , @smithjd wrote:
  
  > Technically, this check isn't actually needed, though it does prevent the 
user from entering a path more than once. At first glance this looks like it 
should work:
  >
  >   if (folder.startsWith(path))
  >
  >
  > This doesn't prevent the user from also re-specifying valid paths.
  
  
  Exact matches are already rejected in the block above.
  
  `folder.startsWith(path)` is also pointless, a user should be allowed to e.g. 
exclude `/foo/` if `/foo/bar/baz is excluded and `/foo/bar` is

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15583: [Balooctl] remove directory parent check

2018-09-23 Thread James Smith
smithjd added a comment.


  Technically, this check isn't actually needed, though it does prevent the 
user from entering a path more than once. At first glance this looks like it 
should work:
  
if (folder.startsWith(path))
  
  This doesn't prevent the user from also re-specifying valid paths.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: smithjd, anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams


D15583: [Balooctl] remove directory parent check

2018-09-22 Thread Nathaniel Graham
ngraham retitled this revision from "[Balooctl] fix directory parent check" to 
"[Balooctl] remove directory parent check".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15583

To: ngraham, #baloo, #dolphin, bruns, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams