D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

2018-09-29 Thread Christoph Cullmann
cullmann added a comment. Thanks for the examples, with that I could reproduce and introduce some hard guard for such cases. Better broken highlighting then an endless hanging application. https://phabricator.kde.org/D15836 REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

2018-09-27 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes. Closed by commit R216:896d3bda6c1d: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new… (authored by nibags). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

2018-09-27 Thread Nibaldo González
nibags added a comment. I attach two files. The "usr.bin.firefox" file causes the error on line 31 and "usr.bin.apparmor-profile-test" on line 184. F6288872: usr.bin.firefox F6288873: usr.bin.apparmor-profile-test

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

2018-09-27 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, I would say: this should go in to workaround the current issue. If you have a file, that triggers the "freeze" with the old version, I would be happy to get it here as

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

2018-09-27 Thread Nibaldo González
nibags added a comment. I did debug with gdb and valgrind, but the information is not relevant, since Kate freezes and I have to kill the process (I think I used the term "crash" incorrectly :S). I have done some tests and the problem is in the use of `#pop!some_context` on the main

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

2018-09-26 Thread Christoph Cullmann
cullmann added a comment. Have you some backtrace from the crash? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15773 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham,

D15773: AppArmor: fix crashes in open rules (in KF5.50) and improvements for the new Solarized schemes

2018-09-26 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY After upgrading to KDE