D15839: extend PlasmaCore.ColorScope for custom colors

[trmdi]

trmdi added a comment.


  !ping

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: trmdi, kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos added a comment.


  F6294480: εικόνα.png 
  [plasma taskmanager that is using red as textColor even though Breeze-Dark 
theme is chosen]

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15839

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15839: extend PlasmaCore.ColorScope for custom colors

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, davidedmundson, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --In the future dynamic coloring might be needed for
  panels in the desktop. In such case panel colors might
  be altered in order to follow the current active maximized
  window colors or another case could be when the panel
  is transparent and plasma theme colors arent providing
  the best constrast with the underlying background.
  This is a first step in order to support panels that color
  themselves independently from the plasma theme or according
  to the plasma theme but with best contrast at all cases.
  
  Usage Example:
  
  //Containment part
  PlasmaCore.ColorScope{
  
colorGroup: PlasmaCore.Theme.UserSetColorGroup
textColor: "#f1f1f1"

/*applets*/
  
  }
  
  //applet part
  
color: PlasmaCore.ColorScope.textColor //it is going to use #f1f1f1

TEST PLAN
  -check that applets are coloring themselves accordingly
  -check that previous behavior didnt break

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  extendColorScope

REVISION DETAIL
  https://phabricator.kde.org/D15839

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h
  src/plasma/theme.h

To: mvourlakos, #plasma, davidedmundson, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns