D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham abandoned this revision. ngraham added a comment. No longer needed with D15935 (or at least, the pressure is off). REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg Cc:

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

cfeck added a comment. I would prefer that. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg Cc: acrouthamel, cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a comment. It's possible to have tiny symbolic emblems that still convey information. Here's a screenshot from my Dropbox folder in Dolphin, with 16x16 icons plus the tiny little emblems that Dropbox adds: F6297941: 8 emblem on 16 icon.png

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

acrouthamel added a comment. What are the different possible emblems that can be applied automatically by the mount process? What if for small sizes, we just use simple shapes and colors. Like a green circle for mounted, and a yellow triangle for something else, and a red square for

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a comment. In D15866#335042 , @cfeck wrote: > The emblem conveys important information; it should be clearly visible. Scaling to size 6 or 12 would only make sense if our icon sets ship those sizes for emblem icons. I

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

cfeck added a comment. The emblem convers important information; it should be clearly visible. Scaling to size 6 or 12 would only make sense if our icon sets ship those sizes for emblem icons. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham,

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a comment. Hmm, that would only make sense for small icons. If we implement it for small icons but keep the overlay style for larger icons, then there will be an odd change if and when the size is increased, and the label will jump horizontally. Also, since this patch is for

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ndavis added a comment. In D15866#334846 , @ngraham wrote: > You mean like this? > > [Icon] [emblem] Label > Yes, like that. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham,

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a comment. In D15866#334519 , @ndavis wrote: > The emblem for the 16px version is too small to read. In D15866#334607 , @broulik wrote: > Did you test this with other

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

broulik added a comment. Did you test this with other icon sets, such as Oxygen? It may work with SVG ones but not pixel-based iconsets. Oxygen only has 8x8 emblems. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ndavis added a comment. The emblem for the 16px version is too small to read. What if instead of the emblem being on top of the icon, it was off to the side? Then it wouldn't matter what size the emblem is as long as it looks good where it is. REPOSITORY R302 KIconThemes REVISION DETAIL

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham added a task: T9740: Improve disk presentation in the Places panel. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D15866 To: ngraham, #frameworks, #dolphin, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY An icon's emblem can take up 25% of the total icon area in certain