D15943: [balooctl] Monitor also for state changes

[Igor Poboiko]

poboiko closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15943: [balooctl] Monitor also for state changes

[Stefan Brüns]

bruns added a comment.


  In D15943#337522 , @poboiko wrote:
  
  > In D15943#337385 , @ngraham 
wrote:
  >
  > > Works for me and the code looks sane. Looks like this fixes 
https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and 
`FIXED-IN: 5.52` to the summary section and also make the changes that @bruns 
requested? Thanks!
  >
  >
  > Weird, bug 364858 should be fine as it is - user asks for a way to display 
files Baloo is currently processing, but that's exactly what `monitor` does 
(even without this patch).
  
  
  I think 364858 is not affected by this, but is still broken.
  
  The monitor command watches for **changes** of the filename, but misses to 
fetch `currentFile` on startup. When the indexer "hangs", we never get a signal.

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15943: [balooctl] Monitor also for state changes

[Igor Poboiko]

poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15943: [balooctl] Monitor also for state changes

[Igor Poboiko]

poboiko added a comment.


  In D15943#337385 , @ngraham wrote:
  
  > Works for me and the code looks sane. Looks like this fixes 
https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and 
`FIXED-IN: 5.52` to the summary section and also make the changes that @bruns 
requested? Thanks!
  
  
  Weird, bug 364858 should be fine as it is - user asks for a way to display 
files Baloo is currently processing, but that's exactly what `monitor` does 
(even without this patch).
  
  > Also, please don't commit this until after Frameworks 5.51 has been tagged 
(which is tomorrow). This is the kind of change that we should have a month to 
test out ourselves before releasing it to customers.
  
  Sure, totally agree!

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15943: [balooctl] Monitor also for state changes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me and the code looks sane. Looks like this fixes 
https://bugs.kde.org/show_bug.cgi?id=364858, so can you add `BUG: 364858` and 
`FIXED-IN: 5.52` to the summary section and also make the changes that @bruns 
requested? Thanks!
  
  Also, please don't commit this until after Frameworks 5.51 has been tagged 
(which is tomorrow). This is the kind of change that we should have a month to 
test out ourselves before releasing it to customers.

REPOSITORY
  R293 Baloo

BRANCH
  monitor-state (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo, ngraham
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D15943: [balooctl] Monitor also for state changes

[Igor Poboiko]

poboiko retitled this revision from "[balooctl] Monitor also for index changes" 
to "[balooctl] Monitor also for state changes".
poboiko edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15943

To: poboiko, #frameworks, #baloo
Cc: bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams