D15973: Add a 'Propreties' entry in the places panel context menu

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileplacesmodel.cpp:957 > > +void KFilePlacesModel::requestProperties(const QModelIndex , QWidget > *parent) > +{ Why is this in the model, rather than

D15973: Add a 'Propreties' entry in the places panel context menu

thsurrel marked an inline comment as done. REPOSITORY R241 KIO BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Propreties' entry in the places panel context menu

thsurrel updated this revision to Diff 43035. thsurrel added a comment. Don't use this-> REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=42984=43035 BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973

D15973: Add a 'Propreties' entry in the places panel context menu

elvisangelaccio added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kfileplacesmodel.cpp:963 > + > +KPropertiesDialog::showDialog(this->url(index), parent); > +} We usually don't use `this->` REPOSITORY R241 KIO BRANCH arc_properties (branched

D15973: Add a 'Propreties' entry in the places panel context menu

ngraham accepted this revision. ngraham added subscribers: anthonyfieroni, elvisangelaccio. ngraham added a comment. This revision is now accepted and ready to land. In your title: Propreties -> Properties Also, add `CCBUG: 181880` to your summary. That will result in the commit details

D15973: Add a 'Propreties' entry in the places panel context menu

This revision now requires review to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15973 To: thsurrel, #frameworks, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Propreties' entry in the places panel context menu

thsurrel updated this revision to Diff 42984. thsurrel added a comment. Use isLocalFile REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15973?vs=42945=42984 BRANCH arc_properties (branched from master) REVISION DETAIL https://phabricator.kde.org/D15973

D15973: Add a 'Propreties' entry in the places panel context menu

thsurrel created this revision. thsurrel added reviewers: Frameworks, VDG, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REVISION SUMMARY Twin of D15929 for dolphin