D15973: Add a 'Propreties' entry in the places panel context menu

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesmodel.cpp:957
>  
> +void KFilePlacesModel::requestProperties(const QModelIndex , QWidget 
> *parent)
> +{

Why is this in the model, rather than being in the view?
It shows a dialog, that sounds more like something for the view.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham, dfaure
Cc: dfaure, elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Thomas Surrel]

thsurrel marked an inline comment as done.

REPOSITORY
  R241 KIO

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Thomas Surrel]

thsurrel updated this revision to Diff 43035.
thsurrel added a comment.


  Don't use this->

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15973?vs=42984=43035

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Elvis Angelaccio]

elvisangelaccio added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kfileplacesmodel.cpp:963
> +
> +KPropertiesDialog::showDialog(this->url(index), parent);
> +}

We usually don't use `this->`

REPOSITORY
  R241 KIO

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added subscribers: anthonyfieroni, elvisangelaccio.
ngraham added a comment.
This revision is now accepted and ready to land.


  In your title: Propreties -> Properties
  
  Also, add `CCBUG: 181880` to your summary. That will result in the commit 
details making it into the Bugzilla ticket, but it won't be closed (since 
D15929  will close it).
  
  Otherwise this looks good and works well! Maybe wait for @elvisangelaccio 
and/or @anthonyfieroni to give their thumbs-up as well before landing the patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham
Cc: elvisangelaccio, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, 
bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Nathaniel Graham]

This revision now requires review to proceed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15973

To: thsurrel, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Thomas Surrel]

thsurrel updated this revision to Diff 42984.
thsurrel added a comment.


  Use isLocalFile

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15973?vs=42945=42984

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15973: Add a 'Propreties' entry in the places panel context menu

[Thomas Surrel]

thsurrel created this revision.
thsurrel added reviewers: Frameworks, VDG, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  Twin of D15929  for dolphin

TEST PLAN
  Right-click on a place or on a device in the Places panel now show a 
Properties entry.
  Clicking on it will open its folder property.

REPOSITORY
  R241 KIO

BRANCH
  arc_properties (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15973

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: thsurrel, #frameworks, #vdg, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns