D16116: [KPropertiesDialog] Show a filename for the / directory

[Thomas Surrel]

thsurrel added a comment.


  It is still missing the '/' for me, but I am on the latest releases, not on 
master right now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D16116: [KPropertiesDialog] Show a filename for the / directory

[Stefan Brüns]

bruns added a comment.


  Is this still relevant - for me, the properties dialog has "Properties for /".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks, ngraham
Cc: bruns, ngraham, kde-frameworks-devel, michaelh

D16116: [KPropertiesDialog] Show a filename for the / directory

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Whoops, missed this.
  
  However, I'm afraid it doesn't work for me, unless I'm holding it wrong:
  
  F6373382: Doesn't seem to work.png 
  
  Looks like `%1` isn't defined here.

REPOSITORY
  R241 KIO

BRANCH
  arc_root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16116: [KPropertiesDialog] Show a filename for the / directory

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Er, whoops.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16116: [KPropertiesDialog] Show a filename for the / directory

[Thomas Surrel]

thsurrel added a comment.


  Ping ! Anyone from #frameworks  
could review this ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16116

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16116: [KPropertiesDialog] Show a filename for the / directory

[Thomas Surrel]

thsurrel created this revision.
thsurrel added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REVISION SUMMARY
  The properties dialog was not showing anything in the window title
  and in the file name label near the icon for the root folder.

TEST PLAN
  Open the properties of the root folder

REPOSITORY
  R241 KIO

BRANCH
  arc_root (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16116

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: thsurrel, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns