D16294: [test/xdgtest] Create/destroy popup on click

2018-10-20 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:99d8548a1c8c: [test/xdgtest] Create/destroy popup on click (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16294?vs=43855=43976#toc REPOSITORY R127 KWayland

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > xdgtest.cpp:202 > QImage image(buffer->address(), size.width(), size.height(), > QImage::Format_ARGB32_Premultiplied); > -image.fill(QColor(255, 0, 0, 255)); > +image.fill(QColor(0, 0, 255, 255)); > Also, you could use Qt::blue. :-)

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread Vlad Zagorodniy
zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > xdgtest.cpp:172 > +positioner.setGravity(Qt::BottomEdge); > +positioner.setConstraints(XdgPositioner::Constraint::FlipX | > XdgPositioner::Constraint::FlipX); > +

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread David Edmundson
davidedmundson edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D16294 To: davidedmundson, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This allows a user to move the windoow before creating the popup