D16294: [test/xdgtest] Create/destroy popup on click

2018-10-20 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:99d8548a1c8c: [test/xdgtest] Create/destroy popup on 
click (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16294?vs=43855=43976#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16294?vs=43855=43976

REVISION DETAIL
  https://phabricator.kde.org/D16294

AFFECTED FILES
  tests/xdgtest.cpp

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> xdgtest.cpp:202
>  QImage image(buffer->address(), size.width(), size.height(), 
> QImage::Format_ARGB32_Premultiplied);
> -image.fill(QColor(255, 0, 0, 255));
> +image.fill(QColor(0, 0, 255, 255));
>  

Also, you could use Qt::blue. :-)

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16294

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread Vlad Zagorodniy 
zzag accepted this revision.
zzag added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> xdgtest.cpp:172
> +positioner.setGravity(Qt::BottomEdge);
> +positioner.setConstraints(XdgPositioner::Constraint::FlipX | 
> XdgPositioner::Constraint::FlipX);
> +m_xdgShellPopup = m_xdgShell->createPopup(m_popupSurface, 
> m_xdgShellSurface, positioner, m_popupSurface);

FlipY?

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16294

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread David Edmundson 
davidedmundson edited the summary of this revision.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16294

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16294: [test/xdgtest] Create/destroy popup on click

2018-10-18 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  This allows a user to move the windoow before creating the popup which
  is extremely useful in testing constraints. Also makes it very easy to
  mod thsi code into a grabbing popup for other tests.
  
  This patch also improve the painted surfaces to show the anchor rect
  around where we place the popup which is easier for visual debugging.
  
  No library code changes

TEST PLAN
  Ran the test
  KWin doesn't position the popup according to all constraints
  Soon will

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16294

AFFECTED FILES
  tests/xdgtest.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns