D16466: [KSambaShare] Add unit test for "net usershare info" parser

[Ben Cooksley]

bcooksley added a comment.


  Thanks for sorting that out.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik, apol
Cc: kossebau, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare info" parser

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Only saw the note from @bcooksley now, pushed an intermediate disabling of 
the new test for windows, so the build at least passes: 
160df8ed7b49f68e74d30cf4343a6251ed4085d8 

  
  Seems some issue with KSambaShare having the KIOCORE_EXPORT macro set, while 
its source is also compiled into the test binary, where the macro resolves to 
import variant. No instant idea how to fix this best, so leaving to original 
code author/windows experts to sort out, sorry :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik, apol
Cc: kossebau, bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare info" parser

[Ben Cooksley]

bcooksley added a comment.


  This change broke the build of KIO on Windows - can someone please take a 
look and correct this?
  
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/71/

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik, apol
Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare info" parser

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:35c861bf146a: [KSambaShare] Add unit test for net 
usershare info parser (authored by bruns).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16466?vs=44322=44811

REVISION DETAIL
  https://phabricator.kde.org/D16466

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ksambashareprivatetest.cpp
  autotests/ksambashareprivatetest.h

To: bruns, #frameworks, broulik, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare info" parser

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  net_usershare

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16466: [KSambaShare] Add unit test for "net usershare info" parser

[Stefan Brüns]

bruns retitled this revision from "[KSambaShare] Add unit test for "net 
usershare list" parser" to "[KSambaShare] Add unit test for "net usershare 
info" parser".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16466

To: bruns, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns