D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-11-06 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. Seems to work, let's push this for now and we will see if there is no regression. REPOSITORY R282 NetworkManagerQt BRANCH ifadded REVISION DETAIL

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-11-05 Thread Fabian Vogt
fvogt added a comment. In D16471#354635 , @jgrulich wrote: > Is this supposed to fix also the issue where when you log into a Plasma session, you first get a notification that it failed to activate a connection and then it gets activated

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-11-05 Thread Jan Grulich
jgrulich added a comment. Is this supposed to fix also the issue where when you log into a Plasma session, you first get a notification that it failed to activate a connection and then it gets activated successfuly? REPOSITORY R282 NetworkManagerQt REVISION DETAIL

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-10-30 Thread Jan Grulich
jgrulich added a comment. > This is RFC because: > > I'm not sure whether it's guaranteed that InterfacesAdded is emitted on service registration as well or both connections are necessary I'm not sure about this either. I'll build it locally and try to use it for a while. > I

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-10-27 Thread Fabian Vogt
fvogt updated this revision to Diff 44334. fvogt added a comment. Fix bad merge REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16471?vs=44332=44334 BRANCH ifadded REVISION DETAIL https://phabricator.kde.org/D16471 AFFECTED FILES

D16471: [RFC] Listen for added DBus interfaces instead of registered services

2018-10-27 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. fvogt requested review of this revision. REVISION SUMMARY When the service is registered, the interfaces might not be available yet. So wait for those instead. BUG: 400359