D16520: proper kwalletd dbus service file for the legacy name

2018-10-31 Thread Stefan Brüns
bruns added a subscriber: FreeBSD.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: #freebsd, bruns, apol, kde-frameworks-devel, michaelh, ngraham


D16520: proper kwalletd dbus service file for the legacy name

2018-10-31 Thread Damjan Georgievski
damjang added a comment.


  is it ok if the waiting on the legacy kwallet4 is made synchronous? wiring 
all those signals will make my head explode :)
  
  wait 5 sec, otherwise give up on the migration?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham


D16520: proper kwalletd dbus service file for the legacy name

2018-10-30 Thread Stefan Brüns
bruns added a comment.


  In D16520#350934 , @damjang wrote:
  
  > > but before doing this change the migration agent has to be changed.
  >
  > Can you expand on this what needs to be changed? I'd be happy to do it if 
it's in my capability
  
  
  There are two possibilities here:
  
  1. Scrap the migration agent completely, only manual wallet migration.
  2. Use execute + listen for NameOwnerChanged DBUS event instead of using the 
current **hackish** D-BUS activation
  
  Re 1., I would like to get  some feedback first -  #FreeBSD 
 is probably the last supported 
distribution still shipping KDE4, and only for 2 more months
  
  Pseudo-Code for 2:
  
kwallet4 = QStandardPaths::findExecutable("kwalletd");
if (kwallet4) {
QProcess process(kwallet4);
process.start();
// wait for 
DBusConnectionInterface::serviceRegistered("org.kde.kwalletd") signal
}

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham


D16520: proper kwalletd dbus service file for the legacy name

2018-10-30 Thread Damjan Georgievski
damjang added a comment.


  > but before doing this change the migration agent has to be changed.
  
  Can you expand on this what needs to be changed? I'd be happy to do it if 
it's in my capability

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Stefan Brüns
bruns added a comment.


  The old kwalletd(4) from kde-runtime newer installed a service file, as far 
as I can see.
  
  The `org.kde.kwalletd.service` from kwalletd5 only serves one purpose - start 
the old kwalletd4 as a source for the migration agent. IMHO the much better 
approach would be to check for `QStandardPaths::findExecutable("kwalletd")`and 
execute it.
  
  The change to the service file is IMHO fine - kwalletd5 implements both 
versions (which are actually the same interface save the service name), but 
before doing this change the migration agent has to be changed.
  
  I also wouldn't mind when the migration agent where gone completely - KDE4 is 
EOL for 3 years, and if there are some persons late to the game they can still 
export the the old wallets manually and reimport.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: bruns, apol, kde-frameworks-devel, michaelh, ngraham


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang added a comment.


  > So now both kdelibs4 and kf5-kwallet will be installing 
org.kde.kwalletd.service and the package manager will complain.
  
  that was the case even before my patch

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Aleix Pol Gonzalez
apol added a comment.


  In D16520#350809 , @damjang wrote:
  
  > in what way exactly?
  >
  > note that the kwallet package already did install org.kde.kwalletd.service, 
but also, kdelibs4 apps should be able to use kwalletd5 via the old interface 
name
  
  
  So now both kdelibs4 and kf5-kwallet will be installing 
org.kde.kwalletd.service and the package manager will complain.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang added a comment.


  In D16520#350807 , @apol wrote:
  
  > Won't this break co-installability with kdelibs4?
  
  
  in what way exactly?
  
  note that the kwallet package already did install org.kde.kwalletd.service, 
but also, kdelibs4 apps should be able to use kwalletd5 via the old interface 
name

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Aleix Pol Gonzalez
apol added a comment.


  Won't this break co-installability with kdelibs4?

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang edited the summary of this revision.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang edited the summary of this revision.

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

To: damjang
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16520: proper kwalletd dbus service file for the legacy name

2018-10-29 Thread Damjan Georgievski
damjang created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
damjang requested review of this revision.

REVISION SUMMARY
the org.kde.kwalletd legacy (kde4) name/interface is implemented by
kwalletd5. this patch makes a proper dbus service file (to
start kwalletd5 for the org.kde.kwalletd bus name, instead of the old
one that tried to start the kde4 wallet daemon

BUG: 400462

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D16520

AFFECTED FILES
  src/runtime/kwalletd/CMakeLists.txt
  src/runtime/kwalletd/org.kde.kwalletd.service
  src/runtime/kwalletd/org.kde.kwalletd.service.in

To: damjang
Cc: kde-frameworks-devel, michaelh, ngraham, bruns