D16801: Fix build on macOS

2018-11-13 Thread Harald Fernengel 
harald abandoned this revision.
harald added a comment.


  Abandoned, already fixed by https://phabricator.kde.org/D16862

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16801

To: harald
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16801: Fix build on macOS

2018-11-13 Thread Harald Fernengel 
harald removed a reviewer: apol.
This revision now requires review to proceed.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16801

To: harald, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16801: Fix build on macOS

2018-11-10 Thread Harald Fernengel 
harald created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
harald requested review of this revision.

REVISION SUMMARY
  On macOS, I'm getting the following error:
  
CMake Error at src/runtime/plugins/CMakeLists.txt:1 (if):
  if given arguments:

"AND" "AND"

  Unknown arguments specified
  
  The reason is the double expansion of arguments in CMake, so instead of `if 
(${FOO})` one should write `if(FOO)`.
  
  This patch fixes the build.

TEST PLAN
  Running `cmake` on Mac OS X passes.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D16801

AFFECTED FILES
  src/runtime/plugins/CMakeLists.txt

To: harald
Cc: kde-frameworks-devel, michaelh, ngraham, bruns