D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread Noah Davis
ndavis added a comment. In D16815#357570 , @ngraham wrote: > I know this is a bugfix, but... > > IMHO it's really bad form to design a Breeze version of an app icon that has a totally different visual style from the original--especially if

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. I know this is a bugfix, but... IMHO it's really bad form to design a Breeze version of an app icon that has a totally different visual style from the original--especially if it completely eliminates all the branding

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I got an error when I tried to land this patch: remote: Audit failure - Commit 5fa9283264f511edf5678cfd09185a16296c7e71 - Non-full name: Rafael I know it might seem

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R266 Breeze Icons BRANCH fix-sublime REVISION DETAIL https://phabricator.kde.org/D16815 To: trickyricky26, #vdg, ndavis Cc: ndavis,

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread TrickyRicky
trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16815 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

2018-11-10 Thread TrickyRicky
trickyricky26 created this revision. trickyricky26 added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REVISION SUMMARY Renamed the Sublime Text icon from sublime.svg to sublime-text.svg to