cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
As said above, I think some "smart wrap" option and that can be used for it.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17128
To: loh.tar,
cullmann added a comment.
I think we could do that in two steps:
1. Introduce some "smart wrap" setting and using generic code like the above
for that
2. If then still we have too many issues, one could outsource that to a js
function (if there, like Dominik proposed).
REPOSITORY
loh.tar added a comment.
Thanks for your input Dominik.
In the meanwhile I noticed (again) these "Smart-Return" function (I noticed,
and used that a couple of years for a short time period, but forgot that
somehow) A reverse version of that should be nice. And somehow the possibility
to
dhaumann added a comment.
As background: inserting the '*' automatically is done by the indenter in
cstyle.js. Theorwtically, we could even add a joinLines function to the
indenters as well and call it if it exists, and if not use the default
implementation. Just an idea... Usually, the
cullmann added a comment.
> An extra action looks to me at first sight a little overdone, but an option
how join behaves may appropriate.
An option in the settings would work for me, too.
I just don't want to destroy the work-flow of people that rely on the current
behavior.
loh.tar added a comment.
> I am not sure if the normal join lines should try to be that clever.
But consider the "auto comment" feature after you hit "Return", it's also
somehow "special clever" but very useful. This tries to add the corresponding
functionality. Well, the true opposite
cullmann added a comment.
Whereas I think such an extension is good, I am not sure if the normal join
lines should try to be that clever.
ATM it is very "deterministic" what happens and I think people like that.
It would make more sense to have an extra action for such a "smart" variant
loh.tar added a comment.
This works so far in most cases I have tried.
- C/C++, // and /* */ works, but sadly not Oxygen style comments. Guess the
single star is not as special marked. Could that be fixed in the highlight
stuff?
- Bash, # works
- Ruby, # works
- Python, # works
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
loh.tar added a project: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
REVISION SUMMARY
...from the next line
