D17178: Don't ask for confimation when reloading

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:82a1673746ea: Dont ask for confimation when 
reloading (authored by nicolasfella).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17178?vs=47740=47918

REVISION DETAIL
  https://phabricator.kde.org/D17178

AFFECTED FILES
  src/document/katedocument.cpp

To: nicolasfella, #kate, ngraham, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17178: Don't ask for confimation when reloading

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok with this, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  arcpatch-D17178

REVISION DETAIL
  https://phabricator.kde.org/D17178

To: nicolasfella, #kate, ngraham, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17178: Don't ask for confimation when reloading

[Nicolas Fella]

nicolasfella updated this revision to Diff 47740.
nicolasfella added a comment.


  - delete m_modOnHdHandler

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17178?vs=46283=47740

BRANCH
  arcpatch-D17178

REVISION DETAIL
  https://phabricator.kde.org/D17178

AFFECTED FILES
  src/document/katedocument.cpp

To: nicolasfella, #kate, ngraham, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17178: Don't ask for confimation when reloading

[Christoph Cullmann]

cullmann added a comment.


  I don't think the change is a bad idea, thought should not the
  
delete m_modOnHdHandler;
  
  stay, to avoid we have the pending message visible?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17178

To: nicolasfella, #kate, ngraham
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17178: Don't ask for confimation when reloading

[Christoph Cullmann]

cullmann requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17178

To: nicolasfella, #kate, ngraham, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D17178: Don't ask for confimation when reloading

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17178

To: nicolasfella, #kate, ngraham
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17178: Don't ask for confimation when reloading

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Kate, ngraham.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When reloading the document it is unnecessary to show the document modified 
dialog that offers to reload 
  since that is what the user expects.

TEST PLAN
  Modify document externally, relaod via F5  -> 
no confirmation dialog

REPOSITORY
  R39 KTextEditor

BRANCH
  noreloadconfirm

REVISION DETAIL
  https://phabricator.kde.org/D17178

AFFECTED FILES
  src/document/katedocument.cpp

To: nicolasfella, #kate, ngraham
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann