D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

2018-12-19 Thread Stefan Brüns 
This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f3a49ddc869a: Move typesForMimeType helper from 
BasicIndexingJob to anonymous namespace (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17338?vs=46820=47849

REVISION DETAIL
  https://phabricator.kde.org/D17338

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/basicindexingjob.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

2018-12-11 Thread Alexander Stippich 
astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17338

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

2018-12-03 Thread Stefan Brüns 
bruns updated this revision to Diff 46820.
bruns added a comment.


  add missing iterator increment

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17338?vs=46810=46820

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17338

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/basicindexingjob.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

2018-12-03 Thread Stefan Brüns 
bruns updated this revision to Diff 46810.
bruns added a comment.


  add missing closing parentheses

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17338?vs=46809=46810

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17338

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/basicindexingjob.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17338: Move typesForMimeType helper from BasicIndexingJob to anonymous namespace

2018-12-03 Thread Stefan Brüns 
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Removes the KFileMetadata include dependency in the header.
  
  While at it, remove the temporary QList, just iterate
  through the hash.
  
  Depends on D17324 

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17338

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/basicindexingjob.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams