D17345: Support Bluetooth batteries

2018-12-04 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R245:b983836f05cd: Support Bluetooth batteries (authored by 
broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17345?vs=46834=46837#toc

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17345?vs=46834=46837

REVISION DETAIL
  https://phabricator.kde.org/D17345

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakebattery.cpp
  src/solid/devices/backends/upower/upowerbattery.cpp
  src/solid/devices/backends/upower/upowerdevice.cpp
  src/solid/devices/frontend/battery.h

To: broulik, #plasma, bruns, davidedmundson, bshah
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

2018-12-04 Thread Bhushan Shah 
bshah accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D17345

To: broulik, #plasma, bruns, davidedmundson, bshah
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

2018-12-04 Thread Kai Uwe Broulik 
broulik added a dependent revision: D17346: Support Bluetooth batteries.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D17345

To: broulik, #plasma, bruns, davidedmundson, bshah
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

2018-12-04 Thread Kai Uwe Broulik 
broulik added a reviewer: bshah.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D17345

To: broulik, #plasma, bruns, davidedmundson, bshah
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17345: Support Bluetooth batteries

2018-12-04 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, bruns, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There's currently no generic Bluetooth device type in UPower, so we get them 
of "unknown" type.
  Check for whether it comes from Bluez to determine it's a Bluetooth battery.

TEST PLAN
  Using upower and bluez git master and a patch to plasma-workspace I now have 
my headset show report its battery level.
  Without plasma-workspace patch it shows up as generic battery but at least it 
shows up
  F6454744: Screenshot_20181204_151718.png 

  "Kopfhörer" is the actual device name, not type, very creative :)

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D17345

AFFECTED FILES
  src/solid/devices/backends/fakehw/fakebattery.cpp
  src/solid/devices/backends/upower/upowerbattery.cpp
  src/solid/devices/backends/upower/upowerdevice.cpp
  src/solid/devices/frontend/battery.h

To: broulik, #plasma, bruns, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns