D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting
dlevin added a comment. Yeah, this might be another bug in the QtCreator (already fixed one crash in their highlighting implementation). They asked me to not put much effort because that code it deprecated anyway in favor or KDE lib. But they just released Creator 4.8.0 and I do not expect any major updates in the nearest feature. So providing simple workaround in the XML should be good enough. Thanks for the quick review as always! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17522 To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting
This revision was automatically updated to reflect the committed changes. Closed by commit R216:abd1bb407e69: BrightScript: Add workaround for QtCreator endsub highlighting (authored by dlevin, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17522?vs=47414=47474 REVISION DETAIL https://phabricator.kde.org/D17522 AFFECTED FILES data/syntax/brightscript.xml To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. If that helps the QtCreator implementation, I am ok with it, thought I would like to see that they use the framework :P REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17522 To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting
dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY QtCreator requires that keyword should be wrapped with white spaces on both ends. Kate requires only trailing white space after keyword. This patch replaces detection of 'endsub' and 'endfunction' with StringDetect instead of keyword to satisfy both. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17522 AFFECTED FILES data/syntax/brightscript.xml To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
