D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever added a comment. Sure. It's here https://phabricator.kde.org/D17856 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: ngraham, aacid, apol, kde-frameworks-devel, michaelh, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

ngraham added a comment. Can you submit that patch using Phabricator? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: ngraham, aacid, apol, kde-frameworks-devel, michaelh, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever added a comment. Here is a patch that solves the problem: diff --git a/src/core/kconfigini.cpp b/src/core/kconfigini.cpp index 39e5936..b674973 100644 --- a/src/core/kconfigini.cpp +++ b/src/core/kconfigini.cpp @@ -673,7 +673,12 @@ QByteArray

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever added a comment. Found it. This is the failing test. FAIL! : KConfigTest::testEncoding() Compared values are not the same Actual (lines.first()): "[UTF-8:\\xc3\\xb6l]\n" Expected (QByteArray("[UTF-8:\xc3\xb6l]\n")): "[UTF-8:\xC3\xB6l]\n"

D17651: Escape bytes that are larger than or equal to 127 in config files

aacid added a comment. In D17651#383320 , @vandenoever wrote > Can you give some more details? I see no problem on Jenkins. https://build.kde.org/job/Frameworks/job/kconfig/ You need to look harder ;) Those yellow bubbles mean tests are

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever added a comment. Can you give some more details? I see problem on Jenkins. https://build.kde.org/job/Frameworks/job/kconfig/ Since my commits there was one more patch, but it's not related. https://cgit.kde.org/kconfig.git/commit/?id=d90a37b5a1d892d7b0ff7cc3b56c8a6e8c4bfe1a

D17651: Escape bytes that are larger than or equal to 127 in config files

aacid added a comment. You broke the tests with this change. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever marked 2 inline comments as done. vandenoever added a comment. I pushed two encore commits fixing the two raised issues. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: apol, kde-frameworks-devel,

D17651: Escape bytes that are larger than or equal to 127 in config files

dfaure added a comment. Thanks! INLINE COMMENTS > kconfigtest.cpp:1726 > +QVERIFY(file.open()); > +qWarning() << file.fileName(); > +KConfig config(file.fileName(), KConfig::SimpleConfig); Remove (or at least degrade to qDebug, this is not a warning) > kconfigtest.cpp:1739 > +

D17651: Escape bytes that are larger than or equal to 127 in config files

This revision was automatically updated to reflect the committed changes. Closed by commit R237:6a185285ae44: Escape bytes that are larger than or equal to 127 in config files (authored by vandenoever). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D17651: Escape bytes that are larger than or equal to 127 in config files

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R237 KConfig BRANCH utf8 (branched from master) REVISION DETAIL https://phabricator.kde.org/D17651 To: vandenoever, dfaure, arichardson, apol Cc: apol,

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever updated this revision to Diff 47790. vandenoever added a comment. Add a check for reading in the unit test. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17651?vs=47788=47790 BRANCH utf8 (branched from master) REVISION DETAIL

D17651: Escape bytes that are larger than or equal to 127 in config files

vandenoever retitled this revision from "Escape bytes that are larger than 127 in config files" to "Escape bytes that are larger than or equal to 127 in config files". vandenoever edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL