dfaure closed this revision.
dfaure added a comment.
Pushed as
https://commits.kde.org/kinit/c29988a97b3ae7abc0d196a1166eb16ee6c3fa95
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D18089
To: ahmadsamir, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, michaelh,
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Sorry for the delay
REPOSITORY
R303 KInit
BRANCH
klauncher-kateSessionManager (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18089
To: ahmadsamir, dfaure
Cc:
anthonyfieroni added a comment.
+1
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D18089
To: ahmadsamir, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
ahmadsamir added a comment.
Ping.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D18089
To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ahmadsamir added a comment.
I don't have commit access, so please commit the diff.
Thanks.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D18089
To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in klauncher.cpp:340
> To make this less scary (since it's not an error) I would suggest
>
> << "exited without error, request done. status=" <<
Good point. Done.
REPOSITORY
R303
ahmadsamir marked 2 inline comments as done.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D18089
To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ahmadsamir updated this revision to Diff 49063.
ahmadsamir retitled this revision from "KLauncher: handle process dying with
exitStatus 0" to "KLauncher: handle processes exiting without error".
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.
Make commit and debug
