dfaure added a comment.
A unittest for this fix would have been even better ;)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18187
To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:28dacfe07375: [KNewFileMenu] Dont emit fileCreated
when creating a directory (authored by chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
ngraham accepted this revision.
ngraham added a comment.
Test still passes, creating new files and directories still works,
conceptually makes sense, fixes 403100. Thanks for doing this @chinmoyr!
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18187
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18187
To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns
chinmoyr created this revision.
chinmoyr added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.
REVISION SUMMARY
BUG: 403100
TEST PLAN
unit tests pass.
REPOSITORY
R241 KIO
BRANCH
master
