D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread David Faure 
dfaure added a comment.


  A unittest for this fix would have been even better ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18187

To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread Chinmoy Ranjan Pradhan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:28dacfe07375: [KNewFileMenu] Dont emit fileCreated 
when creating a directory (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18187?vs=49251=49254

REVISION DETAIL
  https://phabricator.kde.org/D18187

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Test still passes, creating new files and directories still works, 
conceptually makes sense, fixes 403100. Thanks for doing this @chinmoyr!

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18187

To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread Eike Hein 
hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18187

To: chinmoyr, ngraham, hein
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D18187: [KNewFileMenu] Don't emit fileCreated when creating a directory

2019-01-11 Thread Chinmoy Ranjan Pradhan 
chinmoyr created this revision.
chinmoyr added a reviewer: ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  BUG: 403100

TEST PLAN
  unit tests pass.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18187

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: chinmoyr, ngraham
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns