mart added inline comments.
INLINE COMMENTS
> mart wrote in theme_p.cpp:754
> They can be supplied from the theme too (or used to be) even though most of
> the themes don't
err, forget everything i said, i misunderstood your comment :)
using qgray on the theme backgroundcolor instead of a
mart added inline comments.
INLINE COMMENTS
> broulik wrote in theme_p.cpp:754
> If the theme does not supply background contrast values, they are
> auto-determined from the background color (dark or light), or what do you
> mean?
They can be supplied from the theme too (or used to be) even
broulik added inline comments.
INLINE COMMENTS
> mart wrote in theme_p.cpp:754
> but it wouldn't be guaranteed to be the same of the value stored in the
> config file no?
If the theme does not supply background contrast values, they are
auto-determined from the background color (dark or
mart added inline comments.
INLINE COMMENTS
> broulik wrote in theme_p.cpp:754
> An alternative approach would be to store those values and then do the
> default fallback and `qGray(color(Plasma::Theme::BackgroundColor).rgb()) <
> 127` stuff on the fly on demand.
> It's runtime cpu cycles vs
ngraham added a comment.
Nice, it works great for me!
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D18487
To: broulik, #plasma
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
broulik added inline comments.
INLINE COMMENTS
> theme_p.cpp:754
> }
> backgroundContrast = cg.readEntry("contrast", _contrast);
> backgroundIntensity = cg.readEntry("intensity", _intensity);
An alternative approach would be to store those values and then do the
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
When switching between light and dark system colors, the background contrast
might
