D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-02 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:19c936621729: Improve the Notfication Bell Icon by using 
the KAlarm design (authored by trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18533?vs=50703=50727

REVISION DETAIL
  https://phabricator.kde.org/D18533

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  icons/preferences/32/preferences-desktop-notification-bell.svg

To: trickyricky26, #vdg, ngraham
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-02 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I love it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-notification-bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg, ngraham
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-02 Thread TrickyRicky 
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-02 Thread TrickyRicky 
trickyricky26 updated this revision to Diff 50703.
trickyricky26 added a comment.


  - Use a less flat gradient with a silver ringer

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18533?vs=50280=50703

BRANCH
  improve-notification-bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18533

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  icons/preferences/32/preferences-desktop-notification-bell.svg

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Noah Davis 
ndavis added a comment.


  In D18533#403354 , @ngraham wrote:
  
  > In D18533#403351 , @ndavis wrote:
  >
  > > The ringer inside the bell has contrast issues with the standard Breeze 
Dark background color: F6581679: Screenshot_20190201_131929.png 

  >
  >
  > Yeah, needs a light outline like we do for the clock.
  
  
  Or a different color. TBH, I don't remember seeing many bells with black 
ringers, but it does contrast nicely with the yellow of the bell.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Nathaniel Graham 
ngraham added a comment.


  In D18533#403351 , @ndavis wrote:
  
  > The ringer inside the bell has contrast issues with the standard Breeze 
Dark background color: F6581679: Screenshot_20190201_131929.png 

  
  
  Yeah, needs a light outline like we do for the clock.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Noah Davis 
ndavis added a comment.


  The ringer inside the bell has contrast issues with the standard Breeze Dark 
background color: F6581679: Screenshot_20190201_131929.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Andres Betts 
abetts added a comment.


  In D18533#403337 , @ndavis wrote:
  
  > F6581666: Screenshot_20190201_131014.png 

  >
  > The colors are not very good, but this is what I was talking about. It 
looks more 3D.
  
  
  I would only add to this to lighten up the colors closer to yellow so that it 
retains the brightness that the flat icon had. You can achieve a 3D effect with 
brighter yellows. Orange tends to darken images.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: abetts, ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Noah Davis 
ndavis added a comment.


  F6581666: Screenshot_20190201_131014.png 

  
  The colors are no so good, but this is what I was talking about. It looks 
more 3D.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread Nathaniel Graham 
ngraham added a comment.


  How about putting a line under the little nubbin on top?
  
  F6581659: Bell with nubbin.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-02-01 Thread TrickyRicky 
trickyricky26 added a comment.


  I changed the shape a bit, but making it less flat is difficult: Linear 
gradients look off because of the curvature of the bell.
  
  Other options are blurring a curved object or using mesh gradients, but I'm 
not sure how well, if it all, these will work in icons.
  This is what I have:
  F6581498: preferences-desktop-notification-bell-new.svg.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-31 Thread Nathaniel Graham 
ngraham added a comment.


  Any update/progress on this?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-26 Thread Nathaniel Graham 
ngraham added a comment.


  I actually think this new icon is pretty great as-is (at the minimum, it's 
much better than the existing icon) but I agree that it could benefit from a 
bit more depth.
  
  Here's another idea: maybe tilt the bell a bit to make it looks like it's in 
the middle of ringing--say, 20 degrees clockwise.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ngraham, ndavis, djarvie, kde-frameworks-devel, michaelh, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-26 Thread TrickyRicky 
trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  I will try to visually improve the design.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ndavis, djarvie, kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-26 Thread Noah Davis 
ndavis added a comment.


  In D18533#400011 , @trickyricky26 
wrote:
  
  > I have made some slight adjustments from the original KAlarm design, such 
as a shadow line at the bottom instead of orange, to better fir our style.
  >  Should I make those changes in the original icon as well?
  
  
  I think the icon needs a bit of a redesign. It's too flat. I know it's hard 
to make an icon with no overlapping parts look 3D, but using more stops in the 
gradient to increase the complexity of it and give the curves more depth can 
help.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: ndavis, djarvie, kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-26 Thread Christophe Giboudeaux 
cgiboudeaux added a subscriber: djarvie.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: djarvie, kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-25 Thread TrickyRicky 
trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-25 Thread TrickyRicky 
trickyricky26 added a comment.


  I have made some slight adjustments from the original KAlarm design, such as 
a shadow line at the bottom instead of orange, to better fir our style.
  Should I make those changes in the original icon as well?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-25 Thread TrickyRicky 
trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18533

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18533: Improve the Notfication Bell Icon by using the KAlarm design

2019-01-25 Thread TrickyRicky 
trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-notification-bell-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18533

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  icons/preferences/32/preferences-desktop-notification-bell.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns