D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-05 Thread Elvis Angelaccio 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ba3341c83b18: Fix ENABLE_CLAZY option with clazy = 
1.5 (authored by elvisangelaccio).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18680?vs=50790=50989

REVISION DETAIL
  https://phabricator.kde.org/D18680

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-04 Thread Aleix Pol Gonzalez 
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM, thanks!

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-03 Thread Elvis Angelaccio 
elvisangelaccio edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-03 Thread Elvis Angelaccio 
elvisangelaccio updated this revision to Diff 50790.
elvisangelaccio marked an inline comment as done.
elvisangelaccio added a comment.


  Addressed comments

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18680?vs=50735=50790

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18680

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-02 Thread Antonio Rojas 
arojas added a comment.


  You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to  '-Xclang 
-add-plugin -Xclang clazy' for the plugin to be actually loaded.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: arojas, anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-02 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> KDECMakeSettings.cmake:296
>  if(ENABLE_CLAZY)
> -set(CMAKE_CXX_COMPILE_OBJECT "${CMAKE_CXX_COMPILE_OBJECT} -Xclang 
> -load -Xclang ClangLazy${CMAKE_SHARED_LIBRARY_SUFFIX} -Xclang -add-plugin 
> -Xclang clang-lazy")
> +set(CMAKE_CXX_COMPILE_OBJECT "${CMAKE_CXX_COMPILE_OBJECT} -Xclang 
> -load -Xclang ClazyPlugin${CMAKE_SHARED_LIBRARY_SUFFIX} -Xclang -add-plugin 
> -Xclang clang-lazy")
>  endif()

You can use

  find_library(CLAZY ClazyPlugin${CMAKE_SHARED_LIBRARY_SUFFIX})
  if(NOT CLAZY)

  else

  endif()

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: anthonyfieroni, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, 
bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-02 Thread Elvis Angelaccio 
elvisangelaccio added a comment.


  Note: this will break with older clazy versions. I'm not sure how to prevent 
that.
  One could argue that a developer interested in clazy should probably run the 
latest version anyway...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18680

To: elvisangelaccio, apol, smartins
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-02 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
elvisangelaccio added reviewers: apol, smartins.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  clazy 1.5 renamed its plugin from from ClangLazy.so to ClazyPlugin.so

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18680

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: elvisangelaccio, apol, smartins
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns