D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R216:eda235463cd2: Avoid duplicate *-php.xml files in "data/CMakeLists.txt" (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18746?vs=51542&id=51676 REVISION DETAIL https://phabricator.kde.org/D18746 AFFECTED FILES data/CMakeLists.txt To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"
nibags accepted this revision. nibags added a comment. It's good, I think it's a better solution ;D REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18746 To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"
cullmann updated this revision to Diff 51542. cullmann added a comment. I would propose this, OK for you? REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18746?vs=50913&id=51542 REVISION DETAIL https://phabricator.kde.org/D18746 AFFECTED FILES data/CMakeLists.txt To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"
cullmann commandeered this revision. cullmann edited reviewers, added: nibags; removed: cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18746 To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
Hmm, is source == binary directory allowed at all?
I would prefer to generate the files into a different directory, e.g.
${CMAKE_CURRENT_BINARY_DIR}/syntax/generated, that would avoid them poping up
at all in the search by accident, or?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18746
To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns,
demsking, cullmann, sars, dhaumann
D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY When `CMAKE_CURRENT_SOURCE_DIR` and `CMAKE_CURRENT_BINARY_DIR` are the same directory, the "data/generators/generate-php.pl" script creates the `*-php.xml` files in "data/syntax/", therefore, adding them in `defs` causes them to be loaded twice and warnings of duplicate contexts are shown when compiling: [ 8%] Generating index.katesyntax "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Start" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindHTML" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindEntityRefs" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindPEntityRefs" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindAttributes" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindDTDRules" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Comment" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "CDATA" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "PI" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype Internal Subset" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype Markupdecl" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype Markupdecl DQ" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Doctype Markupdecl SQ" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "El Open" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "El Close" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "El Close 2" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "El Close 3" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "CSS" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "CSS content" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "JS" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "JS content" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "JS comment close" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Value" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Value NQ" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Value DQ" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "Value SQ" "/home/nibaldo/test/syntax-highlighting/data/syntax/html-php.xml" Duplicate context: "FindPHP" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Base" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindSelector" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindFunctions" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindValues" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Annotation" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindUnits" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindStrings" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "FindComments" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Error" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "IsComments" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "SelectAtRule" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "@keyframes" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "Within-@keyframes" "/home/nibaldo/test/syntax-highlighting/data/syntax/css-php.xml" Duplicate context: "@viewport" "/home/nibaldo/test/syntax-highlighting/data/syntax/
