D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

This revision was automatically updated to reflect the committed changes. Closed by commit R824:a2ebf9dd3b51: Skip base64 encoding of QDataStream, avoid temporary QByteArray (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R824 Baloo Widgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D19202 To: bruns, #frameworks, #baloo, astippich, ngraham Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

bruns added a comment. Does not really depend on D19268 , but avoids errors due to a incomplete PATH REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D19202 To: bruns, #frameworks, #baloo, astippich, ngraham Cc: domson,

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

bruns added a dependency: D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D19202 To: bruns, #frameworks, #baloo, astippich, ngraham Cc: domson, ashaposhnikov, astippich, spoorun,

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

bruns added a comment. In D19202#418088 , @astippich wrote: > This causes at least one failure in all tests except filemetadatadisplaytest here? the properties are not properly retrieved somehow > and the warning > "Trying to construct an

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

astippich added a comment. This causes at least one failure in all tests except filemetadatadisplaytest here? the properties are not properly retrieved somehow and the warning "Trying to construct an instance of an invalid type, type id: 21123393" is given. REPOSITORY R824 Baloo

D19202: Skip base64 encoding of QDataStream, avoid temporary QByteArray

bruns created this revision. bruns added reviewers: Frameworks, Baloo, astippich, ngraham. Herald added a project: Baloo. bruns requested review of this revision. REVISION SUMMARY There is no need to do any Base64 encoding of the data. Also avoid streaming the data to an intermediate