D19450: DocumentPrivate: Respect indention mode when block selection
This revision was automatically updated to reflect the committed changes. Closed by commit R39:78a2e5d1daa5: DocumentPrivate: Respect indention mode when block selection (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19450?vs=56115=56154 REVISION DETAIL https://phabricator.kde.org/D19450 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D19450: DocumentPrivate: Respect indention mode when block selection
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D19450: DocumentPrivate: Respect indention mode when block selection
cullmann added a comment. Just had not looked at this. Looks reasonable, please push that. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D19450: DocumentPrivate: Respect indention mode when block selection
ngraham added reviewers: Kate, cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor, #kate, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D19450: DocumentPrivate: Respect indention mode when block selection
ngraham edited the summary of this revision. ngraham set the repository for this revision to R39 KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D19450: DocumentPrivate: Respect indention mode when block selection
loh.tar updated this revision to Diff 56115. loh.tar edited the summary of this revision. loh.tar added a comment. - Rebase on master No interest in this? An autotest (place) for this may KateDocumentTest::testReplaceTabs, but not sure. There are slightly other things checked. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19450?vs=52914=56115 REVISION DETAIL https://phabricator.kde.org/D19450 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D19450: DocumentPrivate: Respect indention mode when block selection
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch was in block selection mode always a tab inserted, also when configured to use spaces on tab-key press BUG:395430 Fixed in: 5.57 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19450 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann