D19575: Add collapse-all and expand-all action icons

ndavis updated this revision to Diff 53746. ndavis added a comment. - Add window-shade/unshade REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53744=53746 BRANCH arcpatch-D19575 REVISION DETAIL https://phabricator.kde.org/D19575

D19575: Add collapse-all and expand-all action icons

ndavis updated this revision to Diff 53744. ndavis added a comment. Lower down arrow on expand-all REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53522=53744 BRANCH arcpatch-D19575 REVISION DETAIL https://phabricator.kde.org/D19575

D19575: Add collapse-all and expand-all action icons

ndavis commandeered this revision. ndavis edited reviewers, added: trickyricky26; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: ndavis, #vdg, ngraham, trickyricky26 Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

trickyricky26 added a comment. Sure, go ahead. I'm busy right now REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. @trickyricky26 do you mind if I commandeer this so I can get it finished today? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Could you align the top of the down arrow in expand-all to the pixel grid and move it down by 1px? Like so: F6677924: Screenshot_20190309_114706.png

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

trickyricky26 updated this revision to Diff 53522. trickyricky26 added a comment. - Use design by @ndavis with tighter spacing REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53430=53522 BRANCH collapse-expand-all-icons (branched from

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. Use these, they're more similar to the titlebar shade button, but aligned to the pixel grid better. I will change the `go-*` icons in another patch. F6674647: collapse-all16.svg F6674648: collapse-all22.svg

D19575: Add collapse-all and expand-all action icons

trickyricky26 updated this revision to Diff 53430. trickyricky26 added a comment. - Name -symbolic icons properly REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53315=53430 BRANCH collapse-expand-all-icons (branched from master) REVISION

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. I just noticed, there is already a `go-top` icon that looks just like `collapse-all`. That's a problem. "Collapse all" is different enough from "Go to top" that they shouldn't be the same icon. I do think that the arrow with the bar on top is more appropriate for

D19575: Add collapse-all and expand-all action icons

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. The symlinks in the symbolic folder should end with `-symbolic` REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham Cc: ndavis, ngraham,

D19575: Add collapse-all and expand-all action icons

ndavis added a comment. In D19575#426762 , @ngraham wrote: > Could we get symlinks for these that point to `window-keep-above` and `window-keep-below` too? Ink KWin, the keep above and keep below icons are different. These are the

D19575: Add collapse-all and expand-all action icons

ngraham added a comment. Could we get symlinks for these that point to `window-keep-above` and `window-keep-below` too? REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg,

D19575: Add collapse-all and expand-all action icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great to me! REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26,

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the summary of this revision. trickyricky26 edited the test plan for this revision. trickyricky26 added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg Cc: kde-frameworks-devel, michaelh, ngraham,

D19575: Add collapse-all and expand-all action icons

trickyricky26 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trickyricky26 requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH collapse-expand-all-icons (branched from master) REVISION DETAIL