This revision was automatically updated to reflect the committed changes.
Closed by commit R39:df555c9b2e57: honor auto-bracket setting for balance check
(authored by cullmann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D19608?vs=56105=58298#toc
REPOSITORY
R39 KTextEditor
CHANGES
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
I think moving the config check some lines up will do the trick.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19608
To: loh.tar, #ktexteditor, cullmann,
dhaumann added a comment.
I think this change introduces a regression: This code does not check for
"view->config()->autoBrackets()", so it's *ALWAYS* active, which I do not want.
Consider this:
if (bla |) { ... }
Now you type && foo(), the result is then:
if (bla && foo()
meven added a comment.
I could have made the commit, but heh.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19608
To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: meven, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson,
michaelh, ngraham, bruns,
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:8f0813f6c7ed: DocumentPrivate: Make bracket handling smart
(authored by loh.tar).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D19608?vs=53444=56105#toc
REPOSITORY
R39 KTextEditor
CHANGES
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Works for me, beside that the patch no longer cleanly applies.
But with some false removed and the later parts skipped, it did work as
advertised.
REPOSITORY
R39 KTextEditor
loh.tar edited the summary of this revision.
loh.tar set the repository for this revision to R39 KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D19608
To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor,
loh.tar updated this revision to Diff 53444.
loh.tar retitled this revision from "[WIP] DocumentPrivate: Make bracket
handling smart" to "DocumentPrivate: Make bracket handling smart".
loh.tar edited the test plan for this revision.
loh.tar added a comment.
- Fixes to pass autotests
CHANGES
