D19646: Redesign KDE Connect and bluetooth config pages
nicolasfella updated this revision to Diff 60261. nicolasfella added a comment. - Implement Nates suggestion - Look for Kirigami REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19646?vs=60258=60261 BRANCH arcpatch-D19646 REVISION DETAIL https://phabricator.kde.org/D19646 AFFECTED FILES CMakeLists.txt src/plugins/bluetooth/bluetoothplugin_config.qml src/plugins/kdeconnect/kdeconnectplugin_config.qml src/widgets/JobDialog.qml To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
nicolasfella added inline comments. INLINE COMMENTS > apol wrote in kdeconnectplugin_config.qml:41 > Use icon.name. iconName comes from the DeviceModel. We just expose the name, not the actual ico from KDE Connect REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
nicolasfella updated this revision to Diff 60258. nicolasfella added a comment. - Implement Nates suggestion REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19646?vs=53554=60258 BRANCH arcpatch-D19646 REVISION DETAIL https://phabricator.kde.org/D19646 AFFECTED FILES src/plugins/bluetooth/bluetoothplugin_config.qml src/plugins/kdeconnect/kdeconnectplugin_config.qml src/widgets/JobDialog.qml To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
apol added a comment. This adds a dependency to Kirigami. We are already tier2 so that's okay, but reflect it on CMake at least. INLINE COMMENTS > kdeconnectplugin_config.qml:41 > text: model.display > +icon: model.iconName > onClicked: root.device = deviceId Use icon.name. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
abetts added a comment. Could there be a checkmark box or some way to indicate what selection has been made? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: abetts, ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
ltoscano added a comment. Less technical note: I think that the commit message should not really about KDE Connect, as the change is reflected on all Purpose's users. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Better! Could we get a frame and a white background behind this list? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D19646: Redesign KDE Connect and bluetooth config pages
nicolasfella created this revision. nicolasfella added reviewers: VDG, apol, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library BRANCH settings REVISION DETAIL https://phabricator.kde.org/D19646 AFFECTED FILES src/plugins/bluetooth/bluetoothplugin_config.qml src/plugins/kdeconnect/kdeconnectplugin_config.qml src/widgets/JobDialog.qml To: nicolasfella, #vdg, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
