D19764: Fix Minimap with QtCurve style

2019-03-31 Thread Dominik Haumann
dhaumann added a comment.


  Thanks for the fix.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19764

To: sars, brauch, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D19764: Fix Minimap with QtCurve style

2019-03-30 Thread Kåre Särs
sars added a comment.


  Yes I also have a memory that there was a bug report about it, but I can't 
find it now

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19764

To: sars, brauch, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D19764: Fix Minimap with QtCurve style

2019-03-30 Thread Kåre Särs
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2b53012b3b50: Fix Minimap with QtCurve style (authored by 
sars).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19764?vs=53895=55057

REVISION DETAIL
  https://phabricator.kde.org/D19764

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: sars, brauch, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D19764: Fix Minimap with QtCurve style

2019-03-29 Thread Sven Brauch
brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Looks sensible, and I think I've even seen this bug already somewhere.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19764

To: sars, brauch, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D19764: Fix Minimap with QtCurve style

2019-03-29 Thread Kåre Särs
sars added reviewers: dhaumann, cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19764

To: sars, brauch, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann


D19764: Fix Minimap with QtCurve style

2019-03-14 Thread Kåre Särs
sars created this revision.
sars added a reviewer: brauch.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
sars requested review of this revision.

REVISION SUMMARY
  The handle of the scrollbar in QtCurve is much smaller than the scrollbar 
width when the minimap is on and does not fill the whole width.
  
  This patch moves to always have the scrollbar-handle use the whole width (-2 
pixels)

TEST PLAN
  No visual difference with Breeze and with QtCurve the minimap scrollbar 
handle now uses the whole width of the scrollbar.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19764

AFFECTED FILES
  src/view/kateviewhelpers.cpp

To: sars, brauch
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann