D20063: Sublime Merge Icon.

ngraham added a comment. Thanks so much @otavva! If you've found this process enjoyable and rewarding, there are plenty more icons needed! :) See

D20063: Sublime Merge Icon.

This revision was automatically updated to reflect the committed changes. Closed by commit R266:69d7182daffc: Sublime Merge Icon. (authored by otavva, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20063?vs=54981=55140 REVISION

D20063: Sublime Merge Icon.

otavva added a comment. kirill.otave...@gmail.com Kirill Otavva (or Otavenko if you wish). REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, cblack, arvidhansson,

D20063: Sublime Merge Icon.

ngraham added a comment. In D20063#440460 , @otavva wrote: > @ndavis > Should I to put it here? Yeah just put it in a comment. > And what is Arcanist tool? I'm a first time here.

D20063: Sublime Merge Icon.

otavva added a comment. @ndavis Should I to put it here? Sorry for stupid question, but I don't understand you fully. And what is Arcanist tool? I'm a first time here. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc:

D20063: Sublime Merge Icon.

ndavis accepted this revision. ndavis added a comment. @otavva I need your email and real name to land your patch with the correct author. If you use the Arcanist tool for patches in the future, you will need to make sure that your real name is set as your Git user name. REPOSITORY R266

D20063: Sublime Merge Icon.

otavva added a comment. Updated it. @ndavis Done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh,

D20063: Sublime Merge Icon.

otavva updated this revision to Diff 54981. otavva edited the summary of this revision. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20063?vs=54935=54981 REVISION DETAIL https://phabricator.kde.org/D20063 AFFECTED FILES

D20063: Sublime Merge Icon.

ngraham added a comment. In D20063#439575 , @ndavis wrote: > but for some reason I see myself as the author of the commit instead of @otavva F6726093: Screenshot_20190327_182023.png That's how it

D20063: Sublime Merge Icon.

ndavis added a comment. Oh wait no, it's not there yet, but it still looks pretty good. However, I did notice this on a closer inspection of the shapes: F6726111: Screenshot_20190327_182820.png @otavva, could you make the top shape more like

D20063: Sublime Merge Icon.

ndavis added a comment. In D20063#439465 , @ngraham wrote: > I don't that version is actually in the patch though. @otavva can you update this patch to have that version of the icon? Then we can get it landed for you. No, it's there,

D20063: Sublime Merge Icon.

ngraham added a comment. I don't that version is actually in the patch though. @otavva can you update this patch to have that version of the icon? Then we can get it landed for you. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis

D20063: Sublime Merge Icon.

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This is very nice. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg,

D20063: Sublime Merge Icon.

ngraham added a comment. Ooh, I like it! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde,

D20063: Sublime Merge Icon.

otavva added a comment. F6725369: Screenshot_20190327_191302.png Maybe this color will be better? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: trickyricky26, filipf, ngraham,

D20063: Sublime Merge Icon.

trickyricky26 added a comment. I think the cyan color is too bright and saturated. It fits the original branding well, but stands out from other Breeze icons. I would suggest using a darker, more blue than cyan color. REPOSITORY R266 Breeze Icons REVISION DETAIL

D20063: Sublime Merge Icon.

otavva added a comment. I think that Sublime Merge use Sublime Text license. It is free for use, too. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg, ndavis Cc: filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk,

D20063: Sublime Merge Icon.

otavva updated this revision to Diff 54935. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20063?vs=54864=54935 REVISION DETAIL https://phabricator.kde.org/D20063 AFFECTED FILES icons-dark/apps/48/sublime-merge.svg icons/apps/48/sublime-merge.svg

D20063: Sublime Merge Icon.

filipf added a comment. Looks good. Since it's a proprietary program just check if they have any restrictions about having to use their icons. And yep, the xmlerrors file should be removed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva,

D20063: Sublime Merge Icon.

ngraham added a reviewer: ndavis. ngraham added a comment. Thanks! The new icon looks good to me. However it looks like an `xmlerrors` file was accidentally added to this patch. Can you remove that? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To:

D20063: Sublime Merge Icon.

otavva added a reviewer: VDG. otavva added a subscriber: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20063 To: otavva, #vdg Cc: #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2,

D20063: Sublime Merge Icon.

otavva created this revision. otavva added a project: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. otavva requested review of this revision. REVISION SUMMARY Just added Sublime Merge icon. F6720983: screenshotSMIcon.png