cullmann added a comment.
Harr, with that change it looks good here. Need that a Diff here or can I
commit without?
> Feel free to commit that.
===
For unit tests: if you have small improvements for the tests that make them
more stable, feel free to commit
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2c2e345d4fbf: Fix to show folding preview when move the
mouse from bottom to top (authored by loh.tar).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
loh.tar added a comment.
> Have the feeling kateview_test testDragAndDrop fails more and more often.
Have already spend a lot of time in look at that but without success
Harr, with that change it looks good here. Need that a Diff here or can I
commit without?
commit
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Lgtm and is more readable, thanks.
REVISION DETAIL
https://phabricator.kde.org/D20852
To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, brauch, kwrite-devel, kde-frameworks-devel,
loh.tar updated this revision to Diff 57082.
loh.tar edited the summary of this revision.
loh.tar edited the test plan for this revision.
loh.tar added a comment.
- Fix missing cleanup in case of unvalid mouse position
- Give members more fitting names
- Remove unneeded
brauch added a comment.
I guess the intention of the highlight delay is that when you move your mouse
across the border, the view doesn't flicker. The 150ms does this well enough
for me, I never see a flicker at least ;)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
REVISION SUMMARY
Without this patch happens in that case nothing. You have to
