D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type

2019-05-19 Thread Nibaldo González
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:71446d3e9e5e: Remove .conf extension from INI 
Files hl, to determine the highlighter using… (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21288?vs=58292=58295

REVISION DETAIL
  https://phabricator.kde.org/D21288

AFFECTED FILES
  data/syntax/ini.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type

2019-05-19 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  OK with that.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  remove-ext-conf-ini

REVISION DETAIL
  https://phabricator.kde.org/D21288

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann


D21288: Remove .conf extension from "INI Files" hl, to determine the highlighter using MIME type

2019-05-19 Thread Nibaldo González
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  BUG: 400290
  
  The extension `.conf` is very generic, since depending on the context, it can 
be used with a different language, and assigning it to the "INI Files" 
highlighter isn't very convenient.
  For example, in "Fontconfig" the XML files have a `.conf` extension.
  
  Therefore, I propose that the `.conf` extension isn't assigned to any syntax 
highlighter, so use the MIME type to determine the highlighting mode in those 
files.
  
  For example, when applying this patch, the Fontconfig files (located in 
`/etc/fonts/`) are highlighted as XML by default.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  remove-ext-conf-ini

REVISION DETAIL
  https://phabricator.kde.org/D21288

AFFECTED FILES
  data/syntax/ini.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann