D21713: Fortran: implement free & fixed formats

nibags added a comment. The files are re-licensed to MIT at: 9c5875af2713 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting,

D21713: Fortran: implement free & fixed formats

dhaumann added inline comments. INLINE COMMENTS > nibags wrote in fortran-free.xml:3 > Include keywords was added in KF5.52, but the implementation had a bug that > was fixed in KF5.53. So far, the files that use this (SCSS and TypeScript) > require 5.53 > > Include-keywords (5.52): >

D21713: Fortran: implement free & fixed formats

nibags added inline comments. INLINE COMMENTS > dhaumann wrote in fortran-free.xml:3 > Is it correct that include keywords was added with 5.53? Include keywords was added in KF5.52, but the implementation had a bug that was fixed in KF5.53. So far, the files that use this (SCSS and TypeScript)

D21713: Fortran: implement free & fixed formats

dhaumann added inline comments. INLINE COMMENTS > fortran-free.xml:3 > + > + section="Sources" > extensions="*.f90;*.F90;*.f95;*.F95;*.f03;*.F03;*.f08;*.F08;" > mimetype="text/x-fortran-src" casesensitive="0" author="Franchin Matteo > (f...@libero.it), Janus Weil" license="LGPL"

D21713: Fortran: implement free & fixed formats

nibags added a comment. Franchin Matteo & Janus Weil responded and agree to the MIT license. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: nononux, kwrite-devel,

D21713: Fortran: implement free & fixed formats

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c579929d8667: Fortran: implement free fixed formats (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D21713: Fortran: implement free & fixed formats

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fortran-fixed-free REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: nononux, kwrite-devel,

D21713: Fortran: implement free & fixed formats

cullmann added a comment. Ok, please merge REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: nononux, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns,

D21713: Fortran: implement free & fixed formats

nibags added a comment. > Is there any progress with the licensing? > Otherwise I assume LGPL would be good enough, if a change isn't possible. Sorry, I forgot to ask the authors (Franchin Matteo & Janus Weil) about the license change to MIT. Now I send an email to them asking. When I

D21713: Fortran: implement free & fixed formats

nononux added a comment. Ok, I'll retry after the merge and propose a change to the test file too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: nononux, kwrite-devel,

D21713: Fortran: implement free & fixed formats

cullmann added a comment. Hi, I would propose that we first merge this as is and then start to improve. For your wanted additions, could you then add matching parts to the test highlighting file that show the improvements (or are there already parts inside that will change)?

D21713: Fortran: implement free & fixed formats

nononux added a comment. Hi, thanks for the patch. I suggest additionnal changes to improve the syntax highlighting for Fortran fixed format. I write fixed format fortran at least once a week using Kate. I can confirm these modifications will be usefull at least for me ;) I tested the

D21713: Fortran: implement free & fixed formats

cullmann added a comment. Is there any progress with the licensing? Otherwise I assume LGPL would be good enough, if a change isn't possible. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann,

D21713: Fortran: implement free & fixed formats

cullmann added a comment. Nice that you take care to integrate that. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,

D21713: Fortran: implement free & fixed formats

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21713 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking,

D21713: Fortran: implement free & fixed formats

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY FEATURE: 372950 REPOSITORY